-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating react-native to 0.70.15 #23279
base: main
Are you sure you want to change the base?
Conversation
js/react_native/e2e/package.json
Outdated
@@ -10,7 +10,7 @@ | |||
}, | |||
"dependencies": { | |||
"react": "^18.1.0", | |||
"react-native": "^0.69.1", | |||
"react-native": "0.70.15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these updates have a ^
prefix like the existing entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just copied the changes from
https://react-native-community.github.io/upgrade-helper/?from=0.69.3&to=0.70.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't have the '^' does that mean you have to have exactly 0.70.15 installed? Is that overly restrictive on a developer or required because a later version may not work?
config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = "arm64"
# Conflicts: # js/react_native/e2e/ios/Podfile # js/react_native/ios/OnnxruntimeModule.xcodeproj/project.pbxproj # js/react_native/ios/Podfile
Description
Updating react-native to 0.70.15
Motivation and Context
To address the issue with the failed checksum after boost switching URL from Jfrog