Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments to sample tests #2100

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Added comments to sample tests #2100

merged 2 commits into from
Jan 10, 2025
+10 −6

Conversation

DmitryVasilevsky
Copy link
Contributor

  1. Added clarification comment why we need two expected strings in sample testing.
  2. Made general comment a normal comment rather than doc comment - otherwise it was bound to the first constant in the file.

@DmitryVasilevsky DmitryVasilevsky added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 3e83ec3 Jan 10, 2025
18 checks passed
@DmitryVasilevsky DmitryVasilevsky deleted the dmitryv/sample_test_comments branch January 10, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpuente-MS orpuente-MS orpuente-MS approved these changes

@swernli swernli swernli approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@idavis idavis Awaiting requested review from idavis idavis is a code owner

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitryVasilevsky @swernli @orpuente-MS