Allow strings to be passed for int args in TextSearch

microsoft · Jan 9, 2025 · 2bf82e6 · 2bf82e6
1 parent 12b6b82
commit 2bf82e6
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/dotnet/src/SemanticKernel.Core/Data/TextSearch/TextSearchExtensions.cs b/dotnet/src/SemanticKernel.Core/Data/TextSearch/TextSearchExtensions.cs
@@ -390,9 +390,16 @@ async Task<IEnumerable<object>> GetSearchResultAsync(Kernel kernel, KernelFuncti
     /// <param name="defaultValue">Default value of the argument.</param>
     private static int GetArgumentValue(KernelArguments arguments, IReadOnlyList<KernelParameterMetadata> parameters, string name, int defaultValue)
     {
-        if (arguments.TryGetValue(name, out var value) && value is int argument)
+        if (arguments.TryGetValue(name, out var value))
         {
-            return argument;
+            if (value is int argument)
+            {
+                return argument;
+            }
+            else if (value is string argumentString && int.TryParse(argumentString, out var parsedArgument))
+            {
+                return parsedArgument;
+            }
         }
 
         value = parameters.FirstOrDefault(parameter => parameter.Name == name)?.DefaultValue;

diff --git a/dotnet/src/SemanticKernel.UnitTests/Data/TextSearchExtensionsTests.cs b/dotnet/src/SemanticKernel.UnitTests/Data/TextSearchExtensionsTests.cs
@@ -149,6 +149,21 @@ public async Task CountCanBeOverriddenInArgumentsAsync(KernelFunction function,
         Assert.Equal(5, results.Count());
     }
 
+    [Theory]
+    [MemberData(nameof(StandardFunctions))]
+    public async Task CountCanBeOverriddenInArgumentsWithStringAsync(KernelFunction function, string _)
+    {
+        // Act
+        var result = await function.InvokeAsync(new(), new() { ["query"] = "What is the Semantic Kernel?", ["count"] = "5" });
+
+        // Assert
+        Assert.NotNull(result);
+        var results = result.GetValue<IEnumerable<object>>();
+        Assert.NotNull(results);
+        Assert.NotEmpty(results);
+        Assert.Equal(5, results.Count());
+    }
+
     #region private
     /// <summary>
     /// Create the default <see cref="KernelFunctionFromMethodOptions"/> for <see cref="ITextSearch.SearchAsync(string, TextSearchOptions?, CancellationToken)"/>.