Implement tsp namespace for http-client-csharp #5443
Conversation
ArcturusZhang
force-pushed
the
implement-namespace
branch
from
fb24e3a to
4e7b1e3
Compare
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.Generator.CSharp.Input |
…e segment is the same as a client
| // this segment is bad | ||
| badNamespaceSegments.add(lastSegment); | ||
|
|
||
| Logger.getInstance().warn( |
There was a problem hiding this comment.
We should create a specific diagnostic for this as we have an open issue to remove the generic one. This allows customers to opt into and out of warnings they care about.
There was a problem hiding this comment.
Yeah there is a plan about this actually. Good to see we already have an issue to track this.
In general, we need to do some rearrangements on our existing diagnostics, errors, etc to make them more meaningful.
I will create a new diagnostic for it for now. Maybe we need to review it later
| badNamespaceSegments.add(lastSegment); | ||
|
|
||
| Logger.getInstance().warn( | ||
| `bad namespace ${client.clientNamespace} for client ${clientName}, please use @clientNamespace to specify a different namespace or @clientName to specify a different name for the client`, |
There was a problem hiding this comment.
I don't think we should promote @clientNamespace as this introduces multiple ways to rename things. @clientName can rename any object type.
See this issue for additional comments on this topic
There was a problem hiding this comment.
do you mean we should put @clientName first here in the message?
|
need to add the extension namespace of the pipeline when invoking the extension method from the helpers. |
ArcturusZhang
force-pushed
the
implement-namespace
branch
from
f1709bc to
a544bef
Compare
Fixes #5442
Fixes #5471
This PR contains the following:
removes thenamespaceconfiguration from the emitter because we no longer need it.removes themodel-namespaceconfiguration from the emitter because we no longer need it.Because this change changes the namespace of literally everything, there are quite a few file changed. Majority of them are the generated files changed for the namespace.
For 2 and 3, since it impacts azure generator, I would like to do them in a standalone PR.