Expose public APIs for Azure plugin to generate ResourceData #5544
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live1206
changed the title
live1206
changed the title
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.Generator.CSharp |
live1206
commented
Jan 9, 2025
| private static bool IsWordSeparator(char c) => !SyntaxFacts.IsIdentifierPartCharacter(c) || c == '_'; | ||
|
|
||
| [return: NotNullIfNotNull("name")] | ||
| public static string ToCleanName(string name, bool isCamelCase = true) |
There was a problem hiding this comment.
This is moved from original StringExtensinos.ToCleanName.
Synced with @JoshLove-msft before, we should not expose public extension methods for BCL types, turn them into static methods intead.
There was a problem hiding this comment.
Still not convinced that we need to make this public - https://github.com/Azure/azure-sdk-for-net/pull/47730/files#r1909256494
There was a problem hiding this comment.
OK. Revert it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose more public APIs:
The corresponding Azure plugin PR: Azure/azure-sdk-for-net#47730