Feature command #12014
Open
Feature command #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
bogdandrutu
reviewed
Jan 5, 2025
Signed-off-by: danish9039 <[email protected]>
…elemetry-collector into feature-command
bogdandrutu
reviewed
Jan 6, 2025
Signed-off-by: danish9039 <[email protected]>
bogdandrutu
reviewed
Jan 6, 2025
|
|
||
| func newFeaturesCommand() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "features [feature-id]", |
There was a problem hiding this comment.
@open-telemetry/collector-approvers do you prefer features? gates? featuregates?
There was a problem hiding this comment.
I'd vote for featuregates or feature-gates since that is the full name of the thing being presented by the command. The term features could apply to something than feature gates (like the capabilities of the collector).
bogdandrutu
approved these changes
Jan 6, 2025
songy23
reviewed
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12014 +/- ##
==========================================
+ Coverage 91.67% 91.68% +0.01%
==========================================
Files 455 455
Lines 24038 24072 +34
==========================================
+ Hits 22037 22071 +34
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
TylerHelmuth
reviewed
Jan 9, 2025
Comment on lines
+79
to
+91
| featuregate.GlobalRegistry().VisitAll(func(g *featuregate.Gate) { | ||
| if g.ID() == args[0] { | ||
| found = true | ||
| fmt.Printf("Feature: %s\n", g.ID()) | ||
| fmt.Printf("Enabled: %v\n", g.IsEnabled()) | ||
| fmt.Printf("Stage: %s\n", g.Stage()) | ||
| fmt.Printf("Description: %s\n", g.Description()) | ||
| fmt.Printf("From Version: %s\n", g.FromVersion()) | ||
| if g.ToVersion() != "" { | ||
| fmt.Printf("To Version: %s\n", g.ToVersion()) | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
Doesn't block this PR, but this feature is a great use case for #7625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Testing
makemake testDocumentation