Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unix socket for OTLP with gRPC export of internal telemetry #12059

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jan 9, 2025

Description

This allows specifying a unix socket for the internal telemetry OTLP endpoint, when using gRPC.

Link to tracking issue

Fixes #11941

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (0ece678) to head (af878b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12059   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         455      455           
  Lines       24038    24043    +5     
=======================================
+ Hits        22037    22042    +5     
  Misses       1629     1629           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review January 9, 2025 10:21
@dmathieu dmathieu requested a review from a team as a code owner January 9, 2025 10:21
@dmathieu dmathieu requested a review from jpkrohling January 9, 2025 10:21
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @dmathieu

I will let @codeboten jump onto this since we are planning to delete this otelinit and use the contrib config initialization.

@codeboten feel free to dismiss my change request if you are ok with this, I added here only to ensure you see this.

@codeboten
Copy link
Contributor

Thanks @dmathieu, @bogdandrutu is correct, the code in otelinit will be removed completely in favour of the config package once #11611 lands. It's currently waiting on the next release of otel-go and otel-go-contrib to avoid bumping the minimum go version.

It would be great to add a test to the config package to validate that unix sockets are supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Unix socket for internal telemetry metrics
3 participants