Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[githubgen] PR feedback follow-ups #655

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 7, 2025

This PR

  • adds unit tests here and there to get coverage to a slightly better level
  • refactors many parts of the code to make it better testable
  • refactors parts of the code to be a bit less performant but much more readable (IMO of course)
  • adds new flags to make the tool more suitable for general usage instead of just being focused on OTel Collector Contrib
    • caveat: the flags for now still have defaults that set everything for OTel Collector Contrib (this should probably change in another follow up to keep this PR from exploding)
  • adds githubgen back to the released packages in versions.yaml
  • addresses all feedback comments from feat: add githubgen tool #639

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 54.90196% with 46 lines in your changes missing coverage. Please review.

Project coverage is 50.19%. Comparing base (20a1947) to head (ce7f859).

Files with missing lines Patch % Lines
githubgen/main.go 15.38% 22 Missing ⚠️
githubgen/codeowners.go 70.68% 16 Missing and 1 partial ⚠️
githubgen/issuetemplates.go 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   48.86%   50.19%   +1.32%     
==========================================
  Files          57       57              
  Lines        3381     3405      +24     
==========================================
+ Hits         1652     1709      +57     
+ Misses       1568     1534      -34     
- Partials      161      162       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mowies added 3 commits January 9, 2025 10:27
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the githubgen-follow-up-1 branch 2 times, most recently from 19d4bae to d10937e Compare January 9, 2025 09:58
mowies added 11 commits January 9, 2025 11:01
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the githubgen-follow-up-1 branch from d10937e to 0196800 Compare January 9, 2025 10:01
mowies added 7 commits January 9, 2025 11:04
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies marked this pull request as ready for review January 9, 2025 14:29
@mowies mowies requested review from a team as code owners January 9, 2025 14:29
@mowies mowies requested review from a team as code owners January 9, 2025 14:29
@mowies mowies requested a review from codeboten January 9, 2025 14:29
@mowies mowies mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant