Prevent map lookups in traceglobal
probe when using Go >= 1.24
#1573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1318
The
traceglobal
probe looks up tracers in a map. The current implementation will break for Go >= 1.24 where the map implementation will change. This adds a package constraint to ensure that probe is not loaded in that situation and documents this inCOMPATIBILITY.md
.This was tested manually by setting the package constraint to
Go >= 1.19
and building/running therolldice
example with appropriate versions. The appropriate warnings were logged.Then the cut-off was reverted to
1.24
and the warnings were verified to no longer be logged.