Add remaining ECS attributes for file namespace #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to bump this PR to get attention |
joaopgrassi
reviewed
Apr 18, 2024
|
Please take a look into this PR if there are more questions about these fields or we can proceed? |
… into file_leftovers
|
Just a reminder that this one is ready for approvals :) |
lmolkova
reviewed
May 22, 2024
trisch-me
commented
May 23, 2024
… into file_leftovers
… into file_leftovers
lmolkova
reviewed
Aug 12, 2024
… into file_leftovers
mjwolf
reviewed
Aug 19, 2024
… into file_leftovers
… into file_leftovers
mjwolf
reviewed
Aug 20, 2024
mjwolf
approved these changes
Aug 20, 2024
joaopgrassi
approved these changes
Sep 10, 2024
lmolkova
approved these changes
Sep 18, 2024
lmolkova
reviewed
Sep 21, 2024
|
Putting it in "blocked" until the conflict is fixed. |
… into file_leftovers
…tions into file_leftovers
|
@joaopgrassi conflicts were resolved. thanks |
drewby
pushed a commit
to drewby/otel-semantic-conventions
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Joao Grassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in this PR remaining attributes from ECS for file namespace
Merge requirement checklist
[chore]