Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graduate express to impact stage in readme #1404

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonchurch
Copy link
Contributor

@jonchurch jonchurch commented Jan 7, 2025

cc @UlisesGascon @ctcpip did I get the Impact voting members correct for Express at the bottom of this diff? I don't recall now what is accurate

related to #1378

@jonchurch jonchurch requested a review from a team as a code owner January 7, 2025 17:32
README.md Outdated Show resolved Hide resolved
Copy link

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🥳

Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove Ulises from at-large voting member section and add Wes as the other express voting member

README.md Show resolved Hide resolved
@jonchurch
Copy link
Contributor Author

jonchurch commented Jan 7, 2025

addressed Chris' feedback, removed ulises from at large, added wes and ulises as impact voting for express

@jonchurch jonchurch changed the title move express to impact stage in readme graduate express to impact stage in readme Jan 7, 2025
README.md Show resolved Hide resolved
@ctcpip ctcpip added the fast-track Pull-Requests that don't have time restrictions label Jan 7, 2025
@ctcpip
Copy link
Member

ctcpip commented Jan 7, 2025

requesting fast-track for this: The pull request may be fast-tracked if two CPC members approve the fast-tracking request. To land, the pull request itself still needs two CPC member approvals.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added @wesleytodd's employer if that is still accurate. Its good to display employers on this list. ✌️

README.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wesleytodd
Copy link
Contributor

It is still accurate and was just an oversight.

Co-authored-by: Joe Sepi <[email protected]>
Signed-off-by: Jon Church <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Pull-Requests that don't have time restrictions
Projects
None yet
Development

Successfully merging this pull request may close these issues.