-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DHCPv6 probing to dhcp-discover tool #2128
base: development
Are you sure you want to change the base?
Conversation
Signed-off-by: DL6ER <[email protected]>
…ompiling Signed-off-by: DL6ER <[email protected]>
…all runtime of the dhcp-discover tool Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- src/capabilities.h: Language not supported
- src/config/dnsmasq_config.c: Language not supported
- src/tools/CMakeLists.txt: Language not supported
- src/tools/dhcp-discover.c: Language not supported
- src/tools/dhcp-discover.h: Language not supported
- src/tools/dhcpv6-discover.h: Language not supported
- test/run.sh: Language not supported
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed three things:
Sending ICMPv6 packet: Network unreachable
RAs received on docker0: -1
DHCP packets received on docker0: 0
DHCP packets received on end0: 1
RAs received on end0: 0
Speicherzugriffsfehler
- Docker receiving -1?
- Order of reported RA and DHCP could be better (grouped)
- Memory error. (Does not happen on
development
)
Signed-off-by: DL6ER <[email protected]>
|
Signed-off-by: DL6ER <[email protected]>
Squashed a few insignificant commits |
Interesting, because it was a fresh checkout. Maybe one of the builders failed at some point? Looks good now. Code review will follow.
|
Signed-off-by: Dominik <[email protected]>
Signed-off-by: Dominik <[email protected]>
What does this implement/fix?
This PR extends the embedded
dhcp-discover
to also scan for IPv6 routers possibly broadcasting DNS configuration.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.