Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): cache pip deps in GitHub Actions cache #13141

Closed
wants to merge 1 commit into from

Conversation

miketheman
Copy link
Member

@miketheman
Copy link
Member Author

Per conversation with @ichard26 , this likely will not provide material benefit to speed up CI.

There's no dependency version specification for nox - it's get latest always.

Without a reqirements.txt/pyproject.toml with versions to hash against, the nox version and its dependencies would never be updated, which is also undesirable.

@miketheman miketheman closed this Jan 3, 2025
@miketheman miketheman deleted the ci-cache-pip-deps branch January 3, 2025 20:07
@ichard26
Copy link
Member

ichard26 commented Jan 3, 2025

For context, I was thinking out loud on Discord about ways to speed up the test suite.1 One of those ways is reducing the unnecessary build dependency installations the functional tests perform. I wired up some janky logging, and I observed ~80 seconds spent installing build dependencies (excluding the keyring tests) on a 5-core ~4 minute run. The logging was slightly broken as it reported the installs occuring the test setup phase, hence this drive-by PR, but I explained that these installs are occuring during test execution where the pip cache is disabled anyway.

Furthermore, CI setup also won't benefit from caching as explained by Mike earlier.

Footnotes

  1. I will probably open an issue for this at some point. I just like to share my half-thought-through ideas on Discord. I know it's not ideal as not everyone is there, but the real-time nature is important to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants