Android targetSdk 35 update - remove SafeAreaView and use padding #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use of SafeAreaView and ScrollView.contentInsetAdjustmentBehavior prop.
alanleedev
commented
Jan 9, 2025
| return ( | ||
| <SafeAreaView style={backgroundStyle}> |
There was a problem hiding this comment.
SafeAreaView is removed
alanleedev
commented
Jan 9, 2025
| @@ -62,19 +61,25 @@ function App(): React.JSX.Element { | |||
| backgroundColor: isDarkMode ? Colors.darker : Colors.lighter, | |||
| }; | |||
|
|
|||
| // Note: adding hacky padding to avoid importing rn-safe-area-context library but should not be done in production | |||
| const hackyPadding = '5%'; | |||
There was a problem hiding this comment.
magic padding is used for both iOS and Android
alanleedev
commented
Jan 9, 2025
| <StatusBar | ||
| barStyle={isDarkMode ? 'light-content' : 'dark-content'} | ||
| backgroundColor={backgroundStyle.backgroundColor} | ||
| /> | ||
| <ScrollView | ||
| contentInsetAdjustmentBehavior="automatic" |
There was a problem hiding this comment.
removed iOS only prop: contentInsetAdjustmentBehavior
alanleedev
commented
Jan 9, 2025
| style={backgroundStyle}> | ||
| <Header /> | ||
| <View style={{paddingRight: hackyPadding}}> |
There was a problem hiding this comment.
right padding for RN version indicator
alanleedev
commented
Jan 9, 2025
| <View | ||
| style={{ | ||
| backgroundColor: isDarkMode ? Colors.black : Colors.white, | ||
| paddingHorizontal: hackyPadding, |
There was a problem hiding this comment.
left, right padding for content within ScrollView
alanleedev
commented
Jan 9, 2025
| <View | ||
| style={{ | ||
| backgroundColor: isDarkMode ? Colors.black : Colors.white, | ||
| paddingHorizontal: hackyPadding, | ||
| paddingBottom: hackyPadding, |
There was a problem hiding this comment.
bottom padding to prevent content overlap with button nav bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is an alternative implementation for PR #94 which removes SafeAreaView entirely and uses magic padding for both iOS and Android.
Updating to targetSdk 35 on Android enforces edge-to-edge on Android 15+.
We decided not to use react-native-safe-area-context in the template (PR #84 ) to reduce external dependency although it is the react-native-community/discussions-and-proposals#827.
To account for UI overlap, we are using a magic padding value for both iOS and Android in the template.
Also SafeAreaView (iOS only) was removed so same code is used on both platforms.
Changelog:
[ANDROID][CHANGED] - update targetSdk to 35 which will enforce edge-to-edge on Android 15+
[GENERAL][REMOVED] - Removed use of SafeAreaView
Test Plan:
ios_hacky_padding_only.mp4
ios_hacky_padding_only_land.mp4
android_hacky_padding.mp4
android_hacky_padding_land.mp4