Added the MQTT Writer Block #930
Open
+267
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlersupple
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
PawelPeczek-Roboflow
requested changes
Jan 9, 2025
| ) -> BlockResult: | ||
| client = mqtt.Client() | ||
| try: | ||
| client.connect(host, port) |
There was a problem hiding this comment.
open -> send -> close pattern seems sus regarding performance
Isn't that possible to have con opened through the lifecycle of class?
| return {"status": "Message published successfully"} | ||
| except Exception as e: | ||
| logging.error(f"Failed to publish message: {e}") | ||
| return {"status": f"Failed to publish message: {e}"} |
There was a problem hiding this comment.
Parsing of such error status is impossible programatically - please change into bool statuses
| "version": "v1", | ||
| "short_description": "Publishes messages to an MQTT broker.", | ||
| "long_description": "This block allows publishing messages to a specified MQTT broker and topic.", | ||
| "license": "Apache-2.0", |
There was a problem hiding this comment.
Have you checked that this block is supposed to be under Apache? Please clarify before moving forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the MQTT Writer block. This block enables users to publish messages to an MQTT broker through Workflows.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
Added the
paho-mqttlibrary.Docs
N/A