fallback to authed workspace api key for getting public projects #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there is no api key for the workspace specified in the project url - fix some typos / misspellings
yeldarby
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a project id for e.g. commands like
roboflow project get augmented-startups/playing-cards-ow27d, we use the workspace in the porject id to look up the api key. However, for public projects on universe, we need to use the api key of one of the authed workspaces instead. This was kind of working when e.g. just specifying the project url without the workspace url (e.g.roboflow project get playing-cards-ow27d).This PR changes it so we check whether we have a API key for the project specific workspace, and if not we fallback to getting the api for an authed workspace (wither default workspace or the one specified via
--workspaceoptionAlso fixed some typos (one mentioned here and renaming
getApiKeyWorWorkspaceto getApiKeyForWorkspace