Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC build errors in PCA example #3037

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented Jan 8, 2025

Add missing copy constructor or assignment operators to fix GCC "implicitly-declared operator= is deprecated" and similar errors in pca_cor_dense_batch example.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@Vika-F Vika-F added the bug label Jan 8, 2025
@david-cortes-intel
Copy link
Contributor

@Vika-F I understand some of the CI jobs here should be compiling and running the examples where this issue was found.

Could this problematic behavior be replicated in the CI jobs? For example, by passing flag -Werror=deprecated-copy or similar.

Would be ideal to first create a CI reproducer to make sure that this PR fixes the issue, and to ensure that there aren't other similar issues coming from other examples.

@Vika-F
Copy link
Contributor Author

Vika-F commented Jan 8, 2025

@david-cortes-intel
created a reproducer here #3039

@Vika-F
Copy link
Contributor Author

Vika-F commented Jan 9, 2025

/intelci: run

@Vika-F Vika-F marked this pull request as ready for review January 9, 2025 08:10
@Vika-F Vika-F requested review from david-cortes-intel and removed request for samir-nasibli January 9, 2025 10:36
Copy link
Contributor

@david-cortes-intel david-cortes-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing the earlier compiler error in GCC==11.3 under this PR. Looks like it's working.

@Vika-F Vika-F merged commit 0f70b05 into uxlfoundation:main Jan 10, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants