Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop support for python 3.8 #433

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: drop support for python 3.8 #433

wants to merge 6 commits into from
+352 −350

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jan 7, 2025 •
edited
Loading

Fixes #349

This PR drops support for python 3.8 in the kiota libraries.

In summary, the changes include

  • Dropping using of collection type hint aliases such as Dict, Set and List from typing.
  • Updates projects requirements to include python 3.9+ and drop 3.8
  • Updates validation client to use non deprecated hints via Update validation project with typing updates #434

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

This was referenced Jan 9, 2025
Draft
Open
@andrueastman andrueastman changed the title [WIP] feat: drop support for python 3.8 feat: drop support for python 3.8 Jan 9, 2025
@andrueastman andrueastman marked this pull request as ready for review January 9, 2025 08:30
@andrueastman andrueastman requested a review from a team as a code owner January 9, 2025 08:30
@andrueastman andrueastman mentioned this pull request Jan 9, 2025
Open
3 tasks
baywet
baywet approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also taking the time to clean up the imports of typings to BCL, I had not anticipated that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: In Progress 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop support for python 3.8
2 participants
@andrueastman @baywet